Part of the series, and allows for reliable detection of multi Might be desirable to not iterate over empty lines when polling Generate key events where interconnects are missing. The scan time as status changes were detected, and it won't Not populating logical lines of the matrix will hardly influence Its specific layout (the logical matrix description). The SoC's or module's "potential to drive a matrix", the physical dtsi may specify the GPIO pins for a keypad attachment (say, Of a stretch it's going to get perceived as, but I suggestedĪ. Regarding the usefulness of the patch in the absence of binaryĮncodings which only later get introduced: I can't tell how much Well, the keypad's property (remember the layering between keypadĪnd keymap) has already been there, I just made the matrix keypadĭriver actually use the keymap's DT parse call. > Ignoring the binary encoding in the next patch, why would someone ever > define more row GPIOs that there are rows (or similarly for columns)? > On its own, I don't think this patch is needed. when not > +all of the potentially available physical connections are used to create > +the logical keypad matrix. Optionally device tree > +information can override the keypad matrix dimension data, e.g. By default the keypad matrix dimenstions are automatically > +derived from the GPIO pin specifications. > On 12:09 PM, Gerhard Sittig wrote: > diff -git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt > +The driver assumes that all interconnections of the matrix can potentially > +contain a button, and will submit scan and key code events to the input > +subsystem. On Fri, at 15:41 -0600, Stephen Warren wrote: The changes here should be introduced as part of, and only applicable If that is the situation this patch is intended to cover, GPIOs but only say 6 rows even though there are 8 combinations of row Now, if you add binary encoding, I can see that you might have say 3 row On its own, I don't think this patch is needed. Ignoring the binary encoding in the next patch, why would someone everĭefine more row GPIOs that there are rows (or similarly for columns)? > +The driver assumes that all interconnections of the matrix can potentially > +contain a button, and will submit scan and key code events to the input > +subsystem. > diff -git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt Include/linux/input/matrix_keypad.h | 6 +++ģ files changed, 57 insertions(+), 15 deletions(-) The physical attachment allows for or would suggestĭevice tree setups allow to share the hardware controller's GPIOĪttachment description with M x N intersections, yet individualīoards may use m x n matrix layouts with m The logical layout of the matrix need not be identical to what In the current implementation both aspects of key code mappingĪnd keypad matrix scanning are handled in separate components, The size when not all of the available intersections are used) allow device tree specs to override matrix dimension (reduce cleanly tell physical GPIO connections from logical matrix lines X-Spam-Checker-Version: SpamAssassin 3.3.1 () on RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Subject: input: keypad-matrix: tell GPIO pins from matrix Received: from localhost ( )īy (Postfix) with ESMTPA X-Auth-Info: ENJnpdiL8F8SXwNG9F2ZQgNpDcmWoBsiONz/NEHuzfc= Received: from ()īy localhost ( ) (amavisd-new, Received: from localhost ( )īy (Postfix) with ESMTP id 3bcScN3CYjzbbj9 ( )īy (Postfix) with ESMTP id 3bcScN3bwWz3hj90 Received: from ()īy with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) Received: from localhost ( helo=)īy with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))īy (Postfix) with ESMTPS id 919342012C Received: from (localhost )īy (Postfix) with ESMTP id A093A20140 X-Original-To: from ( )īy (Postfix) with ESMTP id C4FB4C0AB1
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |